On Mon 17 Jan 19:20 CST 2022, Ansuel Smith wrote: > Add cells definition for rpm node and add missing regulators for the 4 > regulator present on ipq8064. There regulators are controlled by rpm and > to correctly works gsbi4_i2c require to be NEVER disabled or rpm will > reject any regulator change request. > Is the SMB208 mandatory on all ipq8064 designs, or should this be pushed out to the device dts? Regards, Bjorn > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx> > --- > arch/arm/boot/dts/qcom-ipq8064.dtsi | 35 +++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > index 094125605bea..824cf13dd037 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > @@ -829,10 +829,45 @@ rpm: rpm@108000 { > clocks = <&gcc RPM_MSG_RAM_H_CLK>; > clock-names = "ram"; > > + #address-cells = <1>; > + #size-cells = <0>; > + > rpmcc: clock-controller { > compatible = "qcom,rpmcc-ipq806x", "qcom,rpmcc"; > #clock-cells = <1>; > }; > + > + regulators { > + compatible = "qcom,rpm-smb208-regulators"; > + > + smb208_s1a: s1a { > + regulator-min-microvolt = <1050000>; > + regulator-max-microvolt = <1150000>; > + > + qcom,switch-mode-frequency = <1200000>; > + }; > + > + smb208_s1b: s1b { > + regulator-min-microvolt = <1050000>; > + regulator-max-microvolt = <1150000>; > + > + qcom,switch-mode-frequency = <1200000>; > + }; > + > + smb208_s2a: s2a { > + regulator-min-microvolt = < 800000>; > + regulator-max-microvolt = <1250000>; > + > + qcom,switch-mode-frequency = <1200000>; > + }; > + > + smb208_s2b: s2b { > + regulator-min-microvolt = < 800000>; > + regulator-max-microvolt = <1250000>; > + > + qcom,switch-mode-frequency = <1200000>; > + }; > + }; > }; > > tcsr: syscon@1a400000 { > -- > 2.33.1 >