On Mon, Jan 31, 2022 at 5:45 AM <conor.dooley@xxxxxxxxxxxxx> wrote: > > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Add device tree bindings for the i2c controller on > the Microchip PolarFire SoC. > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > There should not be a blank line here. Also, tags should be in chronological order typically. If Daire sent this patch out with my tag, then the order is correct. If I gave it on a version you sent, then it goes between Daire's and your S-o-b which is the case here. Rob > Signed-off-by: Daire McNamara <daire.mcnamara@xxxxxxxxxxxxx> > Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>