Hi Shawn,
On Sat, Jan 29, 2022 at 03:09:11PM +0800, Shawn Guo wrote:
> As suggested by commit 9ae8578b517a ("of: Documentation: change overlay
> example to use current syntax"), there is no need to have overlay syntax
> be hard coded in the device tree source file any more.
>
> Signed-off-by: Shawn Guo <shawnguo@xxxxxxxxxx>
> ---
This looks good.
Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
Just one minor comment below:
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts
> index 8ffb707a1576..bd88438c2ecd 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-65bb.dts
> @@ -11,98 +11,78 @@
> /dts-v1/;
> /plugin/;
>
> -/ {
> - fragment@0 {
> - target = <&mdio_slot1>;
> -
> - __overlay__ {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - slot1_sgmii: ethernet-phy@2 {
> - /* AQR112 */
> - reg = <0x2>;
> - compatible = "ethernet-phy-ieee802.3-c45";
> - };
> - };
> - };
> +&mdio_slot1 {
>
Can you please delete this blank line?
> - fragment@1 {
> - target = <&enetc_port0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> - __overlay__ {
> - phy-handle = <&slot1_sgmii>;
> - phy-mode = "2500base-x";
> - managed = "in-band-status";
> - status = "okay";
> - };
> + slot1_sgmii: ethernet-phy@2 {
> + /* AQR112 */
> + reg = <0x2>;
> + compatible = "ethernet-phy-ieee802.3-c45";
> };
> +};
