Hello Samuel,
On 1/30/22 06:38, Samuel Holland wrote:
> rk356x contains a PDM microphone controller which is compatible with the
> existing rockchip,pdm binding. Add its node.
>
> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>
> ---
>
> arch/arm64/boot/dts/rockchip/rk356x.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> index a68033a23975..f2f3cdeab0aa 100644
> --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> @@ -651,6 +651,27 @@ &i2s1m0_sdo0 &i2s1m0_sdo1
> status = "disabled";
> };
>
> + pdm: pdm@fe440000 {
> + compatible = "rockchip,rk3568-pdm";
> + reg = <0x0 0xfe440000 0x0 0x1000>;
> + interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru MCLK_PDM>, <&cru HCLK_PDM>;
> + clock-names = "pdm_clk", "pdm_hclk";
> + dmas = <&dmac1 9>;
> + dma-names = "rx";
> + resets = <&cru SRST_M_PDM>;
> + reset-names = "pdm-m";
> + pinctrl-0 = <&pdmm0_clk
> + &pdmm0_clk1
> + &pdmm0_sdi0
> + &pdmm0_sdi1
> + &pdmm0_sdi2
> + &pdmm0_sdi3>;
> + pinctrl-names = "default";
I think the pinctrl properties should go before the reset properties.
Apart from that this patch looks good to me.
Best regards,
Michael
> + #sound-dai-cells = <0>;
> + status = "disabled";
> + };
> +
> dmac0: dmac@fe530000 {
> compatible = "arm,pl330", "arm,primecell";
> reg = <0x0 0xfe530000 0x0 0x4000>;
