On 1/17/22 12:07, Jayesh Choudhary wrote: >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - ti,dm646x-mcasp-audio >>>> + - ti,da830-mcasp-audio >>>> + - ti,am33xx-mcasp-audio >>>> + - ti,dra7-mcasp-audio >>>> + - ti,omap4-mcasp-audio >> >> This is the only thing which bugs me: the pointless '-audio' postfix for >> the compatible string... >> > > Removing the postfix would also require a lot of dts changes which might > be backward incompatible. So it is probably not a good idea. My plan was to not convert the ti,*-mcasp-audio txt file to yaml in the first place, but do it right with as ti,*-mcasp One of the outstanding issue is the multiple serializer support. It should be in core as things are just working by luck atm when more than one serializer is in use (via the card node). > Should we still consider this? Since we are officially documenting the -mcasp-audio, I don't think it would be a good idea to introduce different binding for the very same IP just for the sake of it. The new (and imho correct) binding would require quite a bit of work in the driver and in the core level (plus the simple-card family), but I'm afraid, I will not have time for it. -- Péter
