Dear all, This is a follow-up on an abandoned series, see [1] Since Dmitry seemed generally happy with the driver, I applied his rename recommendations. I also did a couple of binding fixes which were needed to pass "make dt_binding_check". Thus, I have made the following: * All Reviewed-By: tags were kept * Applied Marco's reviewed by on the bindings (since he approved v10) * Fengping is still the maintainer since he is the original author of this driver * The binding license is not changed even if checkpatch recommended it: > WARNING: DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause) Please tell me if you would rather have me do things differently. [1] https://lore.kernel.org/all/20200909072159.14888-1-fengping.yu@xxxxxxxxxxxx/ v18 -> v19: - bindings: fix maintainer -> maintainers keyword - bindings: add matrix-keymap.yaml ref and remove included properties - bindings: fix compatible strings (reported by make dt_binding_check) - bindings: reorder properties to match the required ones - bindings: remove un-necessary descriptions - bindings: fix multiline description for mediatek,debounce-us - bindings: fix example to pass make dt_binding_check - bindings: fixed licence to GPL-2.0 only (checkpatch) - bindings: rename to mediatek,mt6779-keypad.yaml to match driver - rename driver to mt6779-keypad.c - prefix function names with mt6779_keypad_ - prefix globals with mt6779_keypad_ - rename CONFIG_KEYBOARD_MTK_KPD to CONFIG_KEYBOARD_MT6779 - rename module name to mt6779-keypad - update copyright year to 2022 fengping.yu (3): dt-bindings: input: Add bindings for Mediatek matrix keypad Input: mt6779-keypad - Add MediaTek keypad driver arm64: defconfig: Add CONFIG_KEYBOARD_MT6779=m .../input/mediatek,mt6779-keypad.yaml | 80 +++++++ arch/arm64/configs/defconfig | 1 + drivers/input/keyboard/Kconfig | 12 + drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/mt6779-keypad.c | 218 ++++++++++++++++++ 5 files changed, 312 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml create mode 100644 drivers/input/keyboard/mt6779-keypad.c base-commit: 87a0b2fafc09766d8c55461a18345a1cfb10a7fe -- 2.32.0