Hi Laurent, On Wed, Dec 29, 2021 at 8:31 PM Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> wrote: > The Mitsubishi AA1024XD12 panel can be used for R-Car Gen2 and Gen3 > boards as an optional external panel. It is described in the > arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi file as a direct child of the > DT root node. This allows including r8a77xx-aa104xd12-panel.dtsi in > board device trees, with other minor modifications, to enable the panel. > > This is however not how external components should be modelled. Instead > of modifying the board device tree to enable the panel, it should be > compiled as a DT overlay, to be loaded by the boot loader. > > Prepare the r8a77xx-aa104xd12-panel.dtsi file for this usage by > declaring a panel node only, without hardcoding its path. Overlay > sources can then include r8a77xx-aa104xd12-panel.dtsi where appropriate. > > This change doesn't cause any regression as r8a77xx-aa104xd12-panel.dtsi > is currently unused. As overlay support for this panel has only been > tested with Gen3 hardware, and Gen2 support will require more > development, move the file to arch/arm64/boot/dts/renesas/. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> Thanks for your patch! > --- a/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi > - * Copyright (C) 2014 Renesas Electronics Corp. > +++ b/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi > + * Copyright (C) 2021 Renesas Electronics Corp. Shouldn't you keep the year? Not much has changed. Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds