Hello Sven, Am Tue, Jan 25, 2022 at 10:22:37AM +0100 schrieb sven@xxxxxxxxxxxxxxxx: > From: Sven Schwermer <sven.schwermer@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > As previously discussed [1] on the linux-leds list I am missing > multicolor PWM LED support. In the mean time I have put together a > working prototype for such a driver. This is my first Linux driver > so I'm hoping for some feedback. Here are some questions that came up > while putting this thing together: Wow, I did not expect this so quickly. Thank you. :-) > 1. Currently, the max-brightness property is expected as a property to > the multi-led node. That seems consistent with the existing > multicolor class code, but I'm wondering whether it would make > sense to have a max-brigthness for the individual LEDs as well? > 2. The current multi-led node definition calls for a node index which > would in turn require the reg property to be set within the node. > In this context, that doesn't seem to make sense. Should this > requirement be lifted from leds-class-multicolor.yaml? > 3. I'm not currently reusing any leds-pwm code because there aren't > too many overlaps. Does anyone have suggestions what could be > factored out into a common source file? > > I would appreciate if anyone would test this code. It runs on my > i.MX6ULL-based hardware. > > Best regards, > Sven > > [1]: https://www.spinics.net/lists/linux-leds/msg19988.html You can use the lore.kernel.org archive, e.g. in this case: https://lore.kernel.org/linux-leds/b48eed49-a18e-eed1-f1f4-77b9f1eab39b@xxxxxxxxx/T/#t Greets Alex > > Sven Schwermer (2): > dt-bindings: leds: Add multicolor PWM LED bindings > leds: Add PWM multicolor driver > > .../bindings/leds/leds-pwm-multicolor.yaml | 73 +++++++ > drivers/leds/Kconfig | 8 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-pwm-multicolor.c | 184 ++++++++++++++++++ > 4 files changed, 266 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml > create mode 100644 drivers/leds/leds-pwm-multicolor.c > > -- > 2.35.0 >
