On Mon, Jan 24, 2022 at 11:39 AM LI Qingwu
<Qing-wu.Li@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> Add support for Murata SCL3300, a 3-axis MEMS inclination.
> same as SCA3300, it has accel and temperature output.
accelerometer
> Datasheet link:
> www.murata.com/en-us/products/sensor/inclinometer/overview/lineup/scl3300
>
Make this a Datasheet: tag (change name and drop blank line(s) in the
tag block).
> Signed-off-by: LI Qingwu <Qing-wu.Li@xxxxxxxxxxxxxxxxxxxxxxx>
...
> @@ -68,7 +68,6 @@ static const struct iio_enum sca3300_op_mode_enum = {
> .get = sca3300_get_op_mode,
> .set = sca3300_set_op_mode,
> };
> -
Stray change.
...
> +};
> +
> +
One blank line is enough.
...
> static const int sca3300_accel_scale[CHIP_CNT][OP_MOD_CNT][2] = {
> [CHIP_SCA3300] = {{0, 370}, {0, 741}, {0, 185}, {0, 185}},
> + [CHIP_SCL3300] = {{0, 167}, {0, 333}, {0, 83}, {0, 83}}
+ Comma.
> };
...
> + /*SCL3300 freq.tied to accel scale, not allowed to set separately.*/
Missed spaces.
...
> struct sca3300_data *data = iio_priv(indio_dev);
> -
This even checkpatch should complain of, besides being a stray change.
> switch (mask) {
--
With Best Regards,
Andy Shevchenko
