Hi Alim, > Adds compatible and port configuration for spi controller > for Tesla Full Self-Driving SoC. please next time be a bit clearer in the cover letter. I think you want to say: "This patch adds the compatible..." But it's anyway recommended to use the imperative form: "Add the compatible blah blah blah...." > Cc: linux-fsd@xxxxxxxxx > Signed-off-by: Aswani Reddy <aswani.reddy@xxxxxxxxxxx> > Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> Other than that, looks good to me: Reviewed-by: Andi Shyti <andi@xxxxxxxxxxx> Thanks, Andi
