On Thu, Jan 20, 2022 at 01:34:08PM +0800, Axe Yang wrote: > On Wed, 2022-01-19 at 21:47 +0200, Andy Shevchenko wrote: > > On Wed, Jan 19, 2022 at 06:32:12PM +0800, Axe Yang wrote: ... > > > Signed-off-by: Axe Yang <axe.yang@xxxxxxxxxxxx> > > > > The submitters SoB must be last among all SoB tags. Please, read > > Submitting > > Patches document carefully. > > > > > Signed-off-by: Yong Mao <yong.mao@xxxxxxxxxxxx> > > > > Who is they, why their SoB appeared here? > > Yong Mao is the co-developer of this patch, I will reorder the SoB > chains. And you will need to add a corresponding tag. ... > > > - * Copyright (c) 2014-2015 MediaTek Inc. > > > + * Copyright (c) 2022 MediaTek Inc. > > > > This doesn't feel right. Why did you remove old years? > > I should keep the publish year 2014 of this driver. > But I still think range 2014-2022 is the most appropriate way to change > the copyright time. Over these years, mediatek is keeping maintaining > this driver continuously. What do you think? I guess I already showed my opinion on the topic? The common sense tells me that it should be as simple as '2014-2015,2022' there. -- With Best Regards, Andy Shevchenko
