>-----Original Message----- >From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxxxxx] >Sent: Monday, January 17, 2022 7:20 PM >To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; linux-arm- >kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx >Cc: soc@xxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; >olof@xxxxxxxxx; linus.walleij@xxxxxxxxxx; catalin.marinas@xxxxxxx; >robh+dt@xxxxxxxxxx; s.nawrocki@xxxxxxxxxxx; linux-samsung- >soc@xxxxxxxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx; linux-fsd@xxxxxxxxx; >'Shashank Prashar' <s.prashar@xxxxxxxxxxx>; 'Aswani Reddy' ><aswani.reddy@xxxxxxxxxxx> >Subject: Re: [PATCH 15/23] arm64: dts: fsd: Add initial pinctrl support > >On 17/01/2022 14:44, Alim Akhtar wrote: >> Hi Krzysztof >> >>> -----Original Message----- >>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxxxxx] >>> Sent: Thursday, January 13, 2022 6:50 PM >>> To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; linux-arm- >>> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx >>> Cc: soc@xxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; >>> devicetree@xxxxxxxxxxxxxxx; olof@xxxxxxxxx; linus.walleij@xxxxxxxxxx; >>> catalin.marinas@xxxxxxx; >>> robh+dt@xxxxxxxxxx; s.nawrocki@xxxxxxxxxxx; linux-samsung- >>> soc@xxxxxxxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx; linux-fsd@xxxxxxxxx; >>> Shashank Prashar <s.prashar@xxxxxxxxxxx>; Aswani Reddy >>> <aswani.reddy@xxxxxxxxxxx> >>> Subject: Re: [PATCH 15/23] arm64: dts: fsd: Add initial pinctrl >>> support >>> >>> On 13/01/2022 13:11, Alim Akhtar wrote: >>>> Add initial pin configuration nodes for FSD SoC. >>>> >>>> Cc: linux-fsd@xxxxxxxxx >>>> Signed-off-by: Shashank Prashar <s.prashar@xxxxxxxxxxx> >>>> Signed-off-by: Aswani Reddy <aswani.reddy@xxxxxxxxxxx> >>>> Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> >>>> --- >>>> arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 338 >>> +++++++++++++++++++++ >>>> arch/arm64/boot/dts/tesla/fsd.dtsi | 22 ++ >>>> 2 files changed, 360 insertions(+) >>>> create mode 100644 arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>>> >>>> diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>>> b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>>> new file mode 100644 >>>> index 000000000000..ec8d944af636 >>>> --- /dev/null >>>> +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>>> @@ -0,0 +1,338 @@ >>>> +// SPDX-License-Identifier: GPL-2.0 >>>> +/* >>>> + * Tesla Full Self-Driving SoC device tree source >>>> + * >>>> + * Copyright (c) 2017-2021 Samsung Electronics Co., Ltd. >>>> + * https://www.samsung.com >>>> + * Copyright (c) 2017-2021 Tesla, Inc. >>>> + * https://www.tesla.com >>>> + */ >>>> + >>>> +#include <dt-bindings/pinctrl/samsung.h> >>>> + >>>> +&pinctrl_fsys0 { >>>> + >>> >>> No need for empty line. >>> >> Noted >> >>>> + gpf0: gpf0 { >>> >>> FYI: >>> It's ok now, but the nodes will have to be renamed to "xxx-gpio-bank" >later. >>> >> Have rebased my v2 on your pinmux schema update, so these and below >comments are addressed. >> Thanks >> > >OK, but have in mind that -gpio-bank suffix is not needed now. This depends >on support in the pinctrl driver, which will be applied after the merge window >to different tree or branches than DTS is going to. >Therefore if I apply your DTS with "-gpio-bank" to my next/dt64, the kernel >won't find GPIo banks and won't properly boot. The linux-next will be fine, >just my next/dt64 won't be. > Thanks, got it, for now let me send v2 on linux-next (as of today). As required I will rebase to your next/dt64 and send again. Which also means that my v2 will not be based on your new pinmux schema. Probably we will move to that after the merge window. >If you're fine with it - use "-gpio-bank" suffix. If you prefer my >next/dt64 to have a fully working Tesla SoC DTS, then stick to old node naming >and let's replace it later. > >Best regards, >Krzysztof
