Hi Kieran, On Mon, Jan 17, 2022 at 11:52:10AM +0000, Kieran Bingham wrote: > Quoting Laurent Pinchart (2021-12-12 01:33:51) > > The Draak and Ebisu boards support an optional LVDS panel. One > > compatible panel is the Mitsubishi AA104XD12. Add a corresponding DT > > overlay. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > --- > > arch/arm64/boot/dts/renesas/Makefile | 1 + > > .../renesas/draak-ebisu-panel-aa104xd12.dts | 32 +++++++++++++++++++ > > 2 files changed, 33 insertions(+) > > create mode 100644 arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dts > > > > diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile > > index 982ca3e0e86f..5e831bd33828 100644 > > --- a/arch/arm64/boot/dts/renesas/Makefile > > +++ b/arch/arm64/boot/dts/renesas/Makefile > > @@ -76,3 +76,4 @@ dtb-$(CONFIG_ARCH_R8A77965) += r8a779m5-salvator-xs.dtb > > dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc.dtb > > > > dtb-$(CONFIG_ARCH_RCAR_GEN3) += salvator-panel-aa104xd12.dtbo > > +dtb-$(CONFIG_ARCH_RCAR_GEN3) += draak-ebisu-panel-aa104xd12.dtbo > > diff --git a/arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dts b/arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dts > > new file mode 100644 > > index 000000000000..0c5dc3df5247 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/renesas/draak-ebisu-panel-aa104xd12.dts > > @@ -0,0 +1,32 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Device Tree overlay for the AA104XD12 panel connected to LVDS1 on a Draak or > > + * Ebisu board > > + * > > + * Copyright 2021 Ideas on Board Oy > > + */ > > + > > +/dts-v1/; > > +/plugin/; > > + > > +&{/} { > > +#include "panel-aa104xd12.dtsi" > > +}; > > + > > +&{/panel} { > > + backlight = <&backlight>; > > + > > + port { > > + panel_in: endpoint { > > + remote-endpoint = <&lvds1_out>; > > I guess we can't use parameters in overlays yet? The LVDS reference > seems to be the only difference between the two. But I guess even that > might be hard to pass in as a parameter at boot, or run time... Nobody is working on standardizing parametric overlays as far as I'm aware :-( Support exists in the Rasperry Pi proprietary boot loader, it could be used as a starting point, but we need someone to drive the effort. > > + }; > > + }; > > +}; > > + > > +&lvds1 { > > + status = "okay"; > > +}; > > + > > +&lvds1_out { > > + remote-endpoint = <&panel_in>; > > +}; -- Regards, Laurent Pinchart