On Sun, Jan 16, 2022 at 22:54, Andrew Lunn <andrew@xxxxxxx> wrote: > On Sun, Jan 16, 2022 at 10:15:29PM +0100, Tobias Waldekranz wrote: >> As reported by sparse: In the remove path, the driver would attempt to >> unmap its own priv pointer - instead of the io memory that it mapped >> in probe. > > Hi Tobias > > The change itself is O.K. > > Reviewed-by: Andrew Lunn <andrew@xxxxxxx> > > But you could also change to devm_ so the core will handle the unmap, > it is very unlikely to unmap the wrong thing. Good idea. I have some more changes I want to include in this driver, but they are more net-next material. Will try to work in this change as well.
