Hello Frank,
On 1/16/22 13:49, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>
> pclk_xpcs is not supported and breaks dtbs_check, so remove it
>
> following warnings occour, and many more
>
> rk3568-evb1-v10.dt.yaml: ethernet@fe2a0000: clocks:
> [[15, 386], [15, 389], [15, 389], [15, 184], [15, 180], [15, 181],
> [15, 389], [15, 185], [15, 172]] is too long
> From schema: Documentation/devicetree/bindings/net/snps,dwmac.yaml
> rk3568-evb1-v10.dt.yaml: ethernet@fe2a0000: clock-names:
> ['stmmaceth', 'mac_clk_rx', 'mac_clk_tx', 'clk_mac_refout', 'aclk_mac',
> 'pclk_mac', 'clk_mac_speed', 'ptp_ref', 'pclk_xpcs'] is too long
> From schema: Documentation/devicetree/bindings/net/snps,dwmac.yaml
>
> after removing the clock the other warnings are also gone.
>
> Co-developed-by: Peter Geis <pgwipeout@xxxxxxxxx>
> Signed-off-by: Peter Geis <pgwipeout@xxxxxxxxx>
> Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/rockchip/rk3568.dtsi | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> index 2fd313a295f8..d91df1cde736 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> @@ -32,13 +32,11 @@ gmac0: ethernet@fe2a0000 {
> clocks = <&cru SCLK_GMAC0>, <&cru SCLK_GMAC0_RX_TX>,
> <&cru SCLK_GMAC0_RX_TX>, <&cru CLK_MAC0_REFOUT>,
> <&cru ACLK_GMAC0>, <&cru PCLK_GMAC0>,
> - <&cru SCLK_GMAC0_RX_TX>, <&cru CLK_GMAC0_PTP_REF>,
> - <&cru PCLK_XPCS>;
> + <&cru SCLK_GMAC0_RX_TX>, <&cru CLK_GMAC0_PTP_REF>;
> clock-names = "stmmaceth", "mac_clk_rx",
> "mac_clk_tx", "clk_mac_refout",
> "aclk_mac", "pclk_mac",
> - "clk_mac_speed", "ptp_ref",
> - "pclk_xpcs";
> + "clk_mac_speed", "ptp_ref";
> resets = <&cru SRST_A_GMAC0>;
> reset-names = "stmmaceth";
> rockchip,grf = <&grf>;
This has been on my TODO list for a while, but I never found the time to
submit this cleanup. As far as I am concerned:
Acked-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx>
Thanks and best regards,
Michael
