On Sat 15 Jan 2022 at 10:35, Alexander Stein <alexander.stein@xxxxxxxxxxx> wrote:
> Bindings amlogic,axg-fifo.txt mandates that reset-names is a required
> property. Add it.
Binginds *mandates* ?? the bindings you are adding mandates that, not the
previous doc, nor the driver.
Modifying drivers and DT to accomodate made-up bindings requirement is
disturbing.
The bindings should not require that because the driver does not, as it
stands. The driver requires the arb reset to be provided, not the name.
Please fix the bindings.
>
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxx>
> ---
> This is essentially a preparation for YAML conversion to fix the
> warnings.
>
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 3f5254eeb47b..b14175e2f1d6 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -1333,6 +1333,7 @@ toddr_a: audio-controller@100 {
> interrupts = <GIC_SPI 84 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_TODDR_A>;
> resets = <&arb AXG_ARB_TODDR_A>;
> + reset-names = "arb";
> amlogic,fifo-depth = <512>;
> status = "disabled";
> };
> @@ -1345,6 +1346,7 @@ toddr_b: audio-controller@140 {
> interrupts = <GIC_SPI 85 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_TODDR_B>;
> resets = <&arb AXG_ARB_TODDR_B>;
> + reset-names = "arb";
> amlogic,fifo-depth = <256>;
> status = "disabled";
> };
> @@ -1357,6 +1359,7 @@ toddr_c: audio-controller@180 {
> interrupts = <GIC_SPI 86 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_TODDR_C>;
> resets = <&arb AXG_ARB_TODDR_C>;
> + reset-names = "arb";
> amlogic,fifo-depth = <256>;
> status = "disabled";
> };
> @@ -1369,6 +1372,7 @@ frddr_a: audio-controller@1c0 {
> interrupts = <GIC_SPI 88 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_FRDDR_A>;
> resets = <&arb AXG_ARB_FRDDR_A>;
> + reset-names = "arb";
> amlogic,fifo-depth = <512>;
> status = "disabled";
> };
> @@ -1381,6 +1385,7 @@ frddr_b: audio-controller@200 {
> interrupts = <GIC_SPI 89 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_FRDDR_B>;
> resets = <&arb AXG_ARB_FRDDR_B>;
> + reset-names = "arb";
> amlogic,fifo-depth = <256>;
> status = "disabled";
> };
> @@ -1393,6 +1398,7 @@ frddr_c: audio-controller@240 {
> interrupts = <GIC_SPI 90 IRQ_TYPE_EDGE_RISING>;
> clocks = <&clkc_audio AUD_CLKID_FRDDR_C>;
> resets = <&arb AXG_ARB_FRDDR_C>;
> + reset-names = "arb";
> amlogic,fifo-depth = <256>;
> status = "disabled";
> };
