Hi Rob, On Mon, 2022-01-10 at 14:38 -0600, Rob Herring wrote: > On Thu, Dec 30, 2021 at 07:06:02PM +0100, Sander Vanheule wrote: > > The delay properties are expressed in milliseconds, so the property > > names should have a -ms suffix. Add the suffix, and deprecate the > > original properties. > > > > Signed-off-by: Sander Vanheule <sander@xxxxxxxxxxxxx> > > --- > > .../bindings/power/reset/gpio-restart.yaml | 27 ++++++++++++------- > > 1 file changed, 18 insertions(+), 9 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/power/reset/gpio-restart.yaml > > b/Documentation/devicetree/bindings/power/reset/gpio-restart.yaml > > index 6a1f4aeebf49..13827fe7b395 100644 > > --- a/Documentation/devicetree/bindings/power/reset/gpio-restart.yaml > > +++ b/Documentation/devicetree/bindings/power/reset/gpio-restart.yaml > > @@ -62,17 +62,26 @@ properties: > > restart handlers > > > > active-delay: > > - $ref: /schemas/types.yaml#/definitions/uint32 > > - description: Delay (default 100) to wait after driving gpio active [ms] > > + $ref: '#/properties/active-delay-ms' > > While 'active-delay-ms' has a type because '.*-ms' has a type, you just > removed the type for this property. Now 'active-delay = "foo"' is valid. Good to know, I would've expected the type to be inherited. > While it would be nice to change this, we're pretty much stuck with it > forever. I don't think supporting both versions in the kernel is worth > it. Figured as much. I'll just keep patch 3/3 then. Thanks for the feedback! Best, Sander
