On Mon, Jan 10, 2022 at 02:47:22PM +0800, Li-hao Kuo wrote: > Add devicetree bindings SPI Add bindings doc for Sunplus SP7021 > > Reviewed by Mr. Rob Herring <robh+dt@xxxxxxxxxx> Tag is wrong in multiple ways. It must be exactly what I gave: Acked-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Li-hao Kuo <lhjeff911@xxxxxxxxx> > --- > Changes in v5: > - no change. > - Reviewed by Mr. Rob Herring <robh+dt@xxxxxxxxxx> > > .../bindings/spi/spi-sunplus-sp7021.yaml | 81 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 82 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml > > diff --git a/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml > new file mode 100644 > index 0000000..096bfae > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (C) Sunplus Co., Ltd. 2021 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/spi-sunplus-sp7021.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sunplus sp7021 SPI controller > + > +allOf: > + - $ref: "spi-controller.yaml" > + > +maintainers: > + - Li-hao Kuo <lhjeff911@xxxxxxxxx> > + > +properties: > + compatible: > + enum: > + - sunplus,sp7021-spi > + > + reg: > + items: > + - the SPI master registers > + - the SPI slave registers > + > + reg-names: > + items: > + - const: master > + - const: slave > + > + interrupt-names: > + items: > + - const: dma_w > + - const: mas_risc > + - const: slave_risc > + > + interrupts: > + minItems: 3 > + > + clocks: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - reg-names > + - interrupts > + - interrupt-names > + - clocks > + - clocks-names > + - resets > + - pinctrl-names > + - pinctrl-0 > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/sp-sp7021.h> > + #include <dt-bindings/reset/sp-sp7021.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + spi@9C002D80 { > + compatible = "sunplus,sp7021-spi"; > + reg = <0x9C002D80 0x80>, <0x9C002E00 0x80>; > + reg-names = "master", "slave"; > + interrupt-parent = <&intc>; > + interrupt-names = "dma_w", > + "mas_risc", > + "slave_risc"; > + interrupts = <144 IRQ_TYPE_LEVEL_HIGH>, > + <146 IRQ_TYPE_LEVEL_HIGH>, > + <145 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clkc SPI_COMBO_0>; > + resets = <&rstc RST_SPI_COMBO_0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pins_spi0>; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 1732a9e..2f487be 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -18247,6 +18247,7 @@ SUNPLUS SPI CONTROLLER INTERFACE DRIVER > M: Li-hao Kuo <lhjeff911@xxxxxxxxx> > L: linux-spi@xxxxxxxxxxxxxxx > S: Maintained > +F: Documentation/devicetree/bindings/spi/spi-sunplus-sp7021.yaml > F: drivers/spi/spi-sunplus-sp7021.c > > SUPERH > -- > 2.7.4 > >