Hi Stephen/Michael, I've implemented the feedback received & have RB tags from Geert & Rob. Do you think this could be included on -next? Thanks, Conor. On 16/12/2021 14:00, conor.dooley@xxxxxxxxxxxxx wrote: > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > This patchset adds support for the Microchip PolarFire clkcfg > hardware block. > > Changes since v8: > * Use devm_clk_hw_unregister directly > * Get parent clk in probe rather than register function > > Changes since v7: > * Dropped clock-output-names again (oops) > > Changes since v6: > * Dropped clock-output-names *as a required property* > * Dropped if(lock) check on spinlocks, added spinlocks to all > read-modify-write register access > * Removed kfree()s on non-dynamically allocated variables > * Use devm_clk_get to get the reference clock > * Account for reserved clock when calculating the size of num_clks > > Changes since v5: > * Dropped clock-output-names property > > Major changes since v4: > * Adjusted license for microchip,mpfs-clock.h to match microchip,mpfs.yaml > * Corrected the number of clocks to 33 from 32 > > Major changes since v3: > * Patch reformatted so microchip,mpfs-clock.h is part of device-tree patch > > Major changes since v2: > * In mpfs_cfg_clk_set_rate, return immediately if divider_get_val > returns <0 > * rebased to v5.12-rc1 > > Major changes since v1: > * Dependency on SOC_MICROCHIP_POLARFIRE > * All references to PFSOC/pfsoc changed to MPFS/mpfs > * Cleaned error handling in _probe > * Re-ordered code to place structs et al at top > > Daire McNamara (2): > dt-bindings: clk: microchip: Add Microchip PolarFire host binding > clk: microchip: Add driver for Microchip PolarFire SoC > > .../bindings/clock/microchip,mpfs.yaml | 58 +++ > drivers/clk/Kconfig | 1 + > drivers/clk/Makefile | 2 +- > drivers/clk/microchip/Kconfig | 7 + > drivers/clk/microchip/Makefile | 6 +- > drivers/clk/microchip/clk-mpfs.c | 439 ++++++++++++++++++ > .../dt-bindings/clock/microchip,mpfs-clock.h | 45 ++ > 7 files changed, 555 insertions(+), 3 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clock/microchip,mpfs.yaml > create mode 100644 drivers/clk/microchip/Kconfig > create mode 100644 drivers/clk/microchip/clk-mpfs.c > create mode 100644 include/dt-bindings/clock/microchip,mpfs-clock.h >
