On 10/01/2022 10:35, Yu Tu wrote: > Hi Neil, > Thank you very much for your reply. > > On 2022/1/10 17:27, Neil Armstrong wrote: >> [ EXTERNAL EMAIL ] >> >> Hi, >> >> On 10/01/2022 09:55, Yu Tu wrote: >>> Using the common Clock code to describe the UART baud rate >>> clock makes it easier for the UART driver to be compatible >>> with the baud rate requirements of the UART IP on different >>> meson chips. Add Meson S4 SoC compatible. >>> >>> Yu Tu (5): >>> dt-bindings: serial: meson: Drop compatible = amlogic,meson-gx-uart. >>> tty: serial: meson: Request the register region in meson_uart_probe() >>> tty: serial: meson: The UART baud rate calculation is described using >>> the common clock code. >>> tty: serial: meson: Make the bit24 and bit [26,27] of the UART_REG5 >>> register writable >>> tty: serial: meson: Added S4 SOC compatibility. >> >> Weird, the subjects are fine in the cover letter but are all truncated in the email thread: >> [PATCH V4 0/5] the UART driver compatible with >> [PATCH V4 1/5] dt-bindings: serial: meson: Drop >> [PATCH V4 2/5] tty: serial: meson: Request the register >> ... >> Only the last one is OK. >> > I saw the subject was a little long, I changed it manually, do I need to regenerate and send? yes please, the mail subject will be the commit title so it must be short but descriptive enough. "dt-bindings: serial: meson: Drop" is too short. "dt-bindings: serial: meson: Drop compatible = amlogic,meson-gx-uart" is ok but formulation is wrong, and remove special characters like "=", "[", "]"... The best title could be : "dt-bindings: serial: meson: Drop legacy amlogic,meson-gx-uart compatible" If the subject it too long, reduce it and enhance the commit message with the details. Neil >> >>> >>> V1 -> V2: Use CCF to describe the UART baud rate clock.Make some changes as >>> discussed in the email >>> V2 -> V3: add compatible = "amlogic,meson-gx-uart". Because it must change >>> the DTS before it can be deleted >>> V3 -> V4: Change CCF to describe the UART baud rate clock as discussed >>> in the email. >>> >>> Link:https://lore.kernel.org/linux-amlogic/20211230102110.3861-4-yu.tu@xxxxxxxxxxx/ >>> >>> .../bindings/serial/amlogic,meson-uart.yaml | 10 +- >>> drivers/tty/serial/meson_uart.c | 244 ++++++++++++------ >>> 2 files changed, 177 insertions(+), 77 deletions(-) >>> >>
