Hi Rob, On 1/6/22 9:19 PM, Rob Herring wrote: > 'interrupt-parent' is never required as it can be in a parent node or a > parent node itself can be an interrupt provider. Where exactly it lives is > outside the scope of a binding schema. > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > --- > .../devicetree/bindings/gpio/toshiba,gpio-visconti.yaml | 1 - > .../devicetree/bindings/mailbox/ti,omap-mailbox.yaml | 9 --------- > Documentation/devicetree/bindings/mfd/cirrus,madera.yaml | 1 - > .../devicetree/bindings/net/lantiq,etop-xway.yaml | 1 - > .../devicetree/bindings/net/lantiq,xrx200-net.yaml | 1 - > .../devicetree/bindings/pci/sifive,fu740-pcie.yaml | 1 - > .../devicetree/bindings/pci/xilinx-versal-cpm.yaml | 1 - > 7 files changed, 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > index 9ad470e01953..b085450b527f 100644 > --- a/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > +++ b/Documentation/devicetree/bindings/gpio/toshiba,gpio-visconti.yaml > @@ -43,7 +43,6 @@ required: > - gpio-controller > - interrupt-controller > - "#interrupt-cells" > - - interrupt-parent > > additionalProperties: false > > diff --git a/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml > index e864d798168d..d433e496ec6e 100644 > --- a/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml > +++ b/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml > @@ -175,15 +175,6 @@ required: > - ti,mbox-num-fifos > > allOf: > - - if: > - properties: > - compatible: > - enum: > - - ti,am654-mailbox > - then: > - required: > - - interrupt-parent > - There are multiple interrupt controllers on TI K3 devices, and we need this property to be defined _specifically_ to point to the relevant interrupt router parent node. While what you state in general is true, I cannot have a node not define this on K3 devices, and end up using the wrong interrupt parent (GIC interrupt-controller). That's why the conditional compatible check. regards Suman > - if: > properties: > compatible: > diff --git a/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml b/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml > index 499c62c04daa..5dce62a7eff2 100644 > --- a/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml > +++ b/Documentation/devicetree/bindings/mfd/cirrus,madera.yaml > @@ -221,7 +221,6 @@ required: > - '#gpio-cells' > - interrupt-controller > - '#interrupt-cells' > - - interrupt-parent > - interrupts > - AVDD-supply > - DBVDD1-supply > diff --git a/Documentation/devicetree/bindings/net/lantiq,etop-xway.yaml b/Documentation/devicetree/bindings/net/lantiq,etop-xway.yaml > index 437502c5ca96..3ce9f9a16baf 100644 > --- a/Documentation/devicetree/bindings/net/lantiq,etop-xway.yaml > +++ b/Documentation/devicetree/bindings/net/lantiq,etop-xway.yaml > @@ -46,7 +46,6 @@ properties: > required: > - compatible > - reg > - - interrupt-parent > - interrupts > - interrupt-names > - lantiq,tx-burst-length > diff --git a/Documentation/devicetree/bindings/net/lantiq,xrx200-net.yaml b/Documentation/devicetree/bindings/net/lantiq,xrx200-net.yaml > index 7bc074a42369..5bc1a21ca579 100644 > --- a/Documentation/devicetree/bindings/net/lantiq,xrx200-net.yaml > +++ b/Documentation/devicetree/bindings/net/lantiq,xrx200-net.yaml > @@ -38,7 +38,6 @@ properties: > required: > - compatible > - reg > - - interrupt-parent > - interrupts > - interrupt-names > - "#address-cells" > diff --git a/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml b/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml > index 2b9d1d6fc661..72c78f4ec269 100644 > --- a/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml > @@ -61,7 +61,6 @@ required: > - num-lanes > - interrupts > - interrupt-names > - - interrupt-parent > - interrupt-map-mask > - interrupt-map > - clock-names > diff --git a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml > index a2bbc0eb7220..32f4641085bc 100644 > --- a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml > +++ b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml > @@ -55,7 +55,6 @@ required: > - reg-names > - "#interrupt-cells" > - interrupts > - - interrupt-parent > - interrupt-map > - interrupt-map-mask > - bus-range >
