Hi Gabriel, On Thu, Jan 6, 2022 at 11:50 PM Gabriel L. Somlo <gsomlo@xxxxxxxxx> wrote: > On Thu, Jan 06, 2022 at 08:19:39PM +0200, Andy Shevchenko wrote: > > On Thu, Jan 6, 2022 at 7:48 PM Gabriel Somlo <gsomlo@xxxxxxxxx> wrote: > > > > > > LiteX (https://github.com/enjoy-digital/litex) is a SoC framework > > > that targets FPGAs. LiteSDCard is a small footprint, configurable > > > SDCard core commonly used in LiteX designs. > > > > > > The driver was first written in May 2020 and has been maintained > > > cooperatively by the LiteX community. Thanks to all contributors! > > > > > +config MMC_LITEX > > > + tristate "LiteX MMC Host Controller support" > > > + depends on OF > > > + depends on PPC_MICROWATT || LITEX || COMPILE_TEST > > > + help > > > + This selects support for the MMC Host Controller found in LiteX SoCs. > > > + > > > + If unsure, say N. > > > > What would be the module name if built as a module? > > litex_mmc.ko -- why are you asking? I.e., should I mention that anywhere > in the Kconfig blurb (I don't see other blurbs doing that, fwiw)? Many (most?) blurbs do mention the module name. > > > + div = min(max(div, 2U), 256U); > > > > clamp_t() / clamp_val() ? > > OK, changed to `div = clamp_val(div, 2U, 256U);` Please use clamp() instead of clamp_val(), as all three parameters have the same type (clamp_val() uses casts to align all parameters; casts are evil). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
