On Fri, 31 Dec 2021 21:33:29 -0600, frowand.list@xxxxxxxxx wrote: > From: Frank Rowand <frank.rowand@xxxxxxxx> > > Some overlays are tracked when they are applied. The tracked overlays > are later removed after the overlay tests are completed. The old > implementation makes assumptions about the expected values for > overlay changeset id created by the overlay apply which result > in fragile code. The new code removes the assumptions. > > A symptom that exposes a problem with the tracking code is a > warning "UBSAN: shift-out-of-bounds in drivers/of/unittest.c:1933:36", > Kernel Version: 5.15-rc7, PPC-64, Talos II. This results from variable > "id" value of -1 in the final line of of_unittest_untrack_overlay(). > > Reported-by: erhard_f@xxxxxxxxxxx > Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxx> > --- > drivers/of/unittest.c | 110 +++++++++++++++++++----------------------- > 1 file changed, 49 insertions(+), 61 deletions(-) > Applied, thanks!
