On Mon, Jan 3, 2022 at 10:14 PM Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx> wrote: > > On Tue, 21 Dec 2021 19:15:25 -0400, Rob Herring <robh@xxxxxxxxxx> wrote: > > On Tue, Dec 21, 2021 at 01:40:05PM +0000, Yassine Oudjana wrote: > > > Convert qcom,cpr.txt to DT schema format. > > > > > > Signed-off-by: Yassine Oudjana <y.oudjana@xxxxxxxxxxxxxx> > > > --- > > > .../bindings/power/avs/qcom,cpr.txt | 130 -------------- > > > .../bindings/power/avs/qcom,cpr.yaml | 161 ++++++++++++++++++ > > > MAINTAINERS | 2 +- > > > 3 files changed, 162 insertions(+), 131 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/power/avs/qcom,cpr.txt > > > create mode 100644 Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml > > > > > > > diff --git a/Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml b/Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml > > > new file mode 100644 > > > index 000000000000..852eb36eea93 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml > > > @@ -0,0 +1,161 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/power/avs/qcom,cpr.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Qualcomm Core Power Reduction (CPR) bindings > > > + > > > +maintainers: > > > + - Niklas Cassel <nks@xxxxxxxxxxx> > > > + > > > +description: | > > > + CPR (Core Power Reduction) is a technology to reduce core power on a CPU > > > + or other device. Each OPP of a device corresponds to a "corner" that has > > > + a range of valid voltages for a particular frequency. While the device is > > > + running at a particular frequency, CPR monitors dynamic factors such as > > > + temperature, etc. and suggests adjustments to the voltage to save power > > > + and meet silicon characteristic requirements. > > > + > > > +properties: > > > + compatible: > > > + allOf: > > > > Don't need allOf with only 1 entry. > > I get this from dt_binding_check without it: > > Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml: properties:compatible: [{'items': [{'enum': ['qcom,qcs404-cpr']}, {'const': 'qcom,cpr'}]}] is not of type 'object', 'boolean' Because you made 'compatible' a list rather than a dict/object. 'allOf' is a list of subschemas though. Rob
