Hi Mark, Thank you for the review. On Tue, Jan 04, 2022 at 02:26:45PM +0000, Mark Brown wrote: > On Sun, Jan 02, 2022 at 11:11:23PM +0200, Laurent Pinchart wrote: > > > + patternProperties: > > + "^OUT[1-4]$": > > + type: object > > + $ref: regulator.yaml# > > + > > + required: > > + - OUT1 > > + - OUT2 > > Why are we requiring that there be machine constraints for the > individual regulators? There's already a problem with people just > using the maximum possible control a regulator has as the default for > devices without regard to what the specific system can support. Could you elaborate a bit, keeping in mind that I'm a newbie when it comes to the regulator framework ? :-) The MAX2008[6789] can't control the voltage or current. The outputs can be enabled or disabled individually, but their voltage is fixed to the input voltage. There's overcurrent protection, with a threshold set by a resistor and not known to the driver. The voltage (and current I believe) can be measured, and alarms can be raised through an interrupt. How should I modify the DT bindings to match that correctly ? -- Regards, Laurent Pinchart
