Hi Chris Thanks for the patch. On Mon, 3 Jan 2022 at 17:41, Chris Morgan <macroalpha82@xxxxxxxxx> wrote: > > From: Chris Morgan <macromorgan@xxxxxxxxxxx> > > Add support for the VC4 DPI driver to utilize DPI mode 3. This is > defined here as xxxRRRRRxxGGGGGGxxxBBBBB: > > https://www.raspberrypi.com/documentation/computers/raspberry-pi.html#parallel-display-interface-dpi > > This mode is required to use the Geekworm MZP280 DPI display. > > Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx> Reviewed-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> The other patches all look valid to me, but I'll leave those for the more experienced maintainers. Dave > --- > drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c > index c180eb60bee8..3c58ade2549e 100644 > --- a/drivers/gpu/drm/vc4/vc4_dpi.c > +++ b/drivers/gpu/drm/vc4/vc4_dpi.c > @@ -173,6 +173,10 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) > dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3, > DPI_FORMAT); > break; > + case MEDIA_BUS_FMT_RGB565_1X24_CPADHI: > + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_2, > + DPI_FORMAT); > + break; > default: > DRM_ERROR("Unknown media bus format %d\n", bus_format); > break; > -- > 2.25.1 >
