On 2021/12/30 1:42, Mark Kettenis wrote: >> From: Hector Martin <marcan@xxxxxxxxx> >> Cc: Hector Martin <marcan@xxxxxxxxx>, Sven Peter <sven@xxxxxxxxxxxxx>, >> Alyssa Rosenzweig <alyssa@xxxxxxxxxxxxx>, >> Mark Kettenis <kettenis@xxxxxxxxxxx>, >> Rafał Miłecki <zajec5@xxxxxxxxx>, >> Pieter-Paul Giesberts <pieter-paul.giesberts@xxxxxxxxxxxx>, >> Linus Walleij <linus.walleij@xxxxxxxxxx>, >> Hans de Goede <hdegoede@xxxxxxxxxx>, >> "John W. Linville" <linville@xxxxxxxxxxxxx>, >> "Daniel (Deognyoun) Kim" <dekim@xxxxxxxxxxxx>, >> "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx>, >> linux-wireless@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, >> devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, >> linux-acpi@xxxxxxxxxxxxxxx, brcm80211-dev-list.pdl@xxxxxxxxxxxx, >> SHA-cyfmac-dev-list@xxxxxxxxxxxx >> Date: Mon, 27 Dec 2021 00:35:51 +0900 >> >> This binding is currently used for SDIO devices, but these chips are >> also used as PCIe devices on DT platforms and may be represented in the >> DT. Re-use the existing binding and add chip compatibles used by Apple >> T2 and M1 platforms (the T2 ones are not known to be used in DT >> platforms, but we might as well document them). >> >> Then, add properties required for firmware selection and calibration on >> M1 machines. >> >> Signed-off-by: Hector Martin <marcan@xxxxxxxxx> >> --- >> .../net/wireless/brcm,bcm4329-fmac.yaml | 32 +++++++++++++++++-- >> 1 file changed, 29 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml >> index c11f23b20c4c..2530ff3e7b90 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml >> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml >> @@ -4,7 +4,7 @@ >> $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml# >> $schema: http://devicetree.org/meta-schemas/core.yaml# >> >> -title: Broadcom BCM4329 family fullmac wireless SDIO devices >> +title: Broadcom BCM4329 family fullmac wireless SDIO/PCIE devices >> >> maintainers: >> - Arend van Spriel <arend@xxxxxxxxxxxx> >> @@ -36,16 +36,22 @@ properties: >> - brcm,bcm43455-fmac >> - brcm,bcm43456-fmac >> - brcm,bcm4354-fmac >> + - brcm,bcm4355c1-fmac >> - brcm,bcm4356-fmac >> - brcm,bcm4359-fmac >> + - brcm,bcm4364b2-fmac >> + - brcm,bcm4364b3-fmac >> + - brcm,bcm4377b3-fmac >> + - brcm,bcm4378b1-fmac >> + - brcm,bcm4387c2-fmac >> - cypress,cyw4373-fmac >> - cypress,cyw43012-fmac >> - const: brcm,bcm4329-fmac >> - const: brcm,bcm4329-fmac > > I suppose this helps with validation of device trees. However, nodes > for PCI devices are not supposed to have a "compatible" property as > the PCI vendor and device IDs are supposed to be used to identify a > device. > > That does raise the question how a schema for additional properties > for PCI device nodes is supposed to be defined... Apparently using a "pciVVVV,DDDD" compatible is one way, see bindings/net/wireless/qca,ath9k.yaml There's apparently exactly one example of this in in-tree devicetrees: boot/dts/rockchip/rk3399-gru-chromebook.dtsi I guess this is the way to go then, unless Rob has a different idea :) -- Hector Martin (marcan@xxxxxxxxx) Public Key: https://mrcn.st/pub
