On Fri, Dec 24, 2021 at 8:22 AM Shunzhou.Jiang <shunzhou.jiang@xxxxxxxxxxx> wrote: > > Add support s4 Power controller. In s4, power control > registers are in secure domain, and should be accessed by smc. > > Signed-off-by: Shunzhou.Jiang <shunzhou.jiang@xxxxxxxxxxx> (The same comment about the name as in the dt-bindings patch applies though) I don't have a datasheet to validate any of this but in general the code-change is looking fine. The subject should be changed to "soc: amlogic: meson-secure-pwrc: Add support for the S4 SoC" or similar so it follows the general schema we use there (see the git history) Best regards, Martin
