Am Samstag, 18. Dezember 2021, 16:03:16 CET schrieb Jerome Brunet: > > On Sat 18 Dec 2021 at 15:26, Alexander Stein <alexander.stein@xxxxxxxxxxx> wrote: > > > dtschema expects a 'clocks' property if 'assigned-clocks' is used, but > > 'sound' node does not. > > So move the MPLL[0-2] clock settings &clkc_audio which actually use them. > > No, this does not make sense. > The sound card needs the clocks set in such way - nothing else > The clock controller work just as well regarless of the clock rate > > Having a clock property or not does not change that Well, I checked what others did to fix this warning. So I did the same as in [1]. Despite that, IMHO if you split 'assigned-clocks' for the same clock ´all over users who is gonna win? Because the sound card needs the clocks set his way it is set, it is done in the same file. Best regards, Alexander [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4afb06afd76855932a2d19c983c013105f1cfb9a > > This fixes the dtschema warning: > > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dt.yaml: sound: 'clocks' is a dependency of 'assigned-clocks' > > > > Then the schema needs fixing IMO > > > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxx> > > --- > > .../boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 15 +++++++-------- > > 1 file changed, 7 insertions(+), 8 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > > index 9c05c83453f5..85257507206c 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi > > @@ -252,14 +252,6 @@ sound { > > "U19 INR", "ACODEC LORP", > > "Lineout", "U19 OUTL", > > "Lineout", "U19 OUTR"; > > - > > - assigned-clocks = <&clkc CLKID_MPLL2>, > > - <&clkc CLKID_MPLL0>, > > - <&clkc CLKID_MPLL1>; > > - assigned-clock-parents = <0>, <0>, <0>; > > - assigned-clock-rates = <294912000>, > > - <270950400>, > > - <393216000>; > > status = "okay"; > > > > dai-link-0 { > > @@ -365,6 +357,13 @@ &cecb_AO { > > }; > > > > &clkc_audio { > > + assigned-clocks = <&clkc CLKID_MPLL2>, > > + <&clkc CLKID_MPLL0>, > > + <&clkc CLKID_MPLL1>; > > + assigned-clock-parents = <0>, <0>, <0>; > > + assigned-clock-rates = <294912000>, > > + <270950400>, > > + <393216000>; > > status = "okay"; > > }; > >
