Dear Rob, Thanks for your comments. On Thu, 2021-12-16 at 10:01 -0600, Rob Herring wrote: > On Thu, Dec 16, 2021 at 01:53:26PM +0800, Biao Huang wrote: > > Convert mediatek-dwmac to DT schema, and delete old mediatek- > > dwmac.txt. > > And there are some changes in .yaml than .txt, others almost keep > > the same: > > 1. compatible "const: snps,dwmac-4.20". > > 2. delete "snps,reset-active-low;" in example, since driver > > remove this > > property long ago. > > 3. add "snps,reset-delay-us = <0 10000 10000>" in example. > > 4. the example is for rgmii interface, keep related properties > > only. > > > > Signed-off-by: Biao Huang <biao.huang@xxxxxxxxxxxx> > > --- > > .../bindings/net/mediatek-dwmac.txt | 91 ---------- > > .../bindings/net/mediatek-dwmac.yaml | 155 > > ++++++++++++++++++ > > 2 files changed, 155 insertions(+), 91 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/net/mediatek- > > dwmac.txt > > create mode 100644 Documentation/devicetree/bindings/net/mediatek- > > dwmac.yaml > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> I'll add reviewed-by in next send. Regards!