Re: [PATCH v2 0/3] ARM: mstar: Initial Miyoo Mini support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Daniel,


Le jeu. 16 déc. 2021 à 17:15, Daniel Palmer <daniel@xxxxxxxx> a écrit :
>
> Hi Romain,
>
> On Fri, 17 Dec 2021 at 00:53, Romain Perier <romain.perier@xxxxxxxxx> wrote:
> >
> > Hi Daniel,
> >
> > Le jeu. 16 déc. 2021 à 11:52, Daniel Palmer <daniel@xxxxxxxx> a écrit :
> >>
> >>   - I've left the link tags as-is as using them for linking
> >>     to background info seems acceptable.
> >
> >
> > https://www.kernel.org/doc/html/latest/maintainer/configure-git.html#creating-commit-links-to-lore-kernel-org
>
> The explanation of Link seem to have been updated recently in
> 1f57bd42b77cdc4b8e05ba9f4417872a6691b66d
> (https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
> a few paragraphs down).
>
> My reading of the paragraph since that commit is: Explain what the
> commit does in the commit message. If there is a bug that prompted the
> change then link it. If there is some background for the commit then
> link it.
>
> If it needs to be changed around I'll do that but I personally think
> it looks nicer. It seems like the right way to provide links to
> datasheets etc without putting a bunch of long messy urls into the
> commit message.

Well, I agree it is confusing. So I have discussed privately about
this with Arnd (on IRC):

<rperier> What is the real usage of the "Link:" tag ? it is mainly
used as background informations for referencing archives or patches on
lore.k.o  , but it can also be used for referencing something else or
not ?
(like information for a board)
[...]
<arnd> right, it's pretty much never wrong to add a Link: tag for the
patch submission that was picked up, but you can also add it for any
other reference, e.g.issue trackers or datasheets that may be relevant

----

Which replies to the question, so it is okay for me ;)

Romain




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux