On Tue, 26 Aug 2014, Chris Zhong wrote: > On 08/26/2014 04:44 AM, Doug Anderson wrote: > >On Mon, Aug 25, 2014 at 6:31 AM, Chris Zhong <zyw@xxxxxxxxxxxxxx> wrote: [...] > >You need a Signed-off-by: Zhang Qing <zhangqing@xxxxxxxxxxxxxx> > > Done [...] > >I think Lee's "Grim" comment here was that prefixing globals with "g_" > >is not consistent with the Linux coding style. Just remove the "g_". > > Done [...] > >{ RK808_BUCK3_CONFIG_REG, BUCK_ILMIN_MASK, BUCK_ILMIN_150MA }, > > > >instead of: > > > >{RK808_BUCK3_CONFIG_REG, BUCK_ILMIN_MASK, BUCK_ILMIN_150MA}, > > Done [...] > >nit: add spacing so that VB_LO_SEL_3500MV lines up under VB_LO_ACT > > Done [...] > >I think Lee wanted the above to be: > > > > { "rk808", }, > > Done [...] > >I think Lee wanted you to remove ".owner = THIS_MODULE" > > Done [...] You've just spammed 10(00)'s of people with an email that contains zero useful content. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html