On Tue, Dec 14, 2021 at 05:22:55PM +0100, David Heidelberg wrote: > > > > On Mon, Dec 13 2021 at 17:23:49 -0600, Rob Herring <robh@xxxxxxxxxx> wrote: > > On Mon, 13 Dec 2021 20:29:45 +0100, David Heidelberg wrote: > > > Extend registers up to 2, also document their names. > > > > > > Also fixes warnings generated by `make > > > qcom/sdm845-oneplus-fajita.dtb`: > > > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000: > > > reg: [[24576], [24832]] is too long > > > From schema: > > > Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml > > > arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: rtc@6000: > > > 'reg-names' does not match any of the regexes: 'pinctrl-[0-9]+' > > > From schema: > > > Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml > > > > > > Signed-off-by: David Heidelberg <david@xxxxxxx> > > > --- > > > .../devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml | 9 > > > ++++++++- > > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > following warnings. Consider if they are expected or the schema is > > incorrect. These may not be new warnings. > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > This will change in the future. > > > > Full log is available here: https://patchwork.ozlabs.org/patch/1567467 > > > > > > rtc@11d: compatible: Additional items are not allowed ('qcom,pm8921-rtc' > > was unexpected) > > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml > > > > rtc@11d: compatible: ['qcom,pm8018-rtc', 'qcom,pm8921-rtc'] is too long > > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dt.yaml > > > Would you consider safe, if I sent patch to remove redundant > `qcom,pm8921-rtc` from arch/arm/boot/dts/qcom-mdm9615.dtsi? I don't know. Depends if anything uses that and doesn't know about 'qcom,pm8018-rtc'. Rob