Hi Mark, Thanks for the reviews and advice. On Mon, 2021-12-13 at 16:04 +0000, Mark Brown wrote: > On Sun, Dec 12, 2021 at 04:40:12AM +0800, Tinghan Shen wrote: > > > Some mtk spi nor has dedicated dma(s) inside. Add a new clock name, > > axi, > > for spi nor dma bus clock. > > clock-names: > > + minItems: 2 > > items: > > - const: spi > > - const: sf > > + - const: axi > > This will cause any existing DTs that don't have both spi and sf > clocks > defined to fail to validate which doesn't seem great. Given that > your > commit message says this is only required for some SoCs shouldn't the > minimum clocks requirement depend on which particular SoC/IP version > is > being used? Not exactly sure how one specifies that in the YAML > format. > > Please submit patches using subject lines reflecting the style for > the > subsystem, this makes it easier for people to identify relevant > patches. > Look at what existing commits in the area you're changing are doing > and > make sure your subject lines visually resemble what they're doing. > There's no need to resubmit to fix this alone. I'll update the subject at next version. It'll be "dt-bindings: spi: mtk-spi-nor: ...". regards, TingHan
