On 12/13/21 3:23 PM, Rob Herring wrote: > On Mon, 13 Dec 2021 11:02:21 -0800, Florian Fainelli wrote: >> Conver the iProc PCIe controller Device Tree binding to YAML now that >> all DTS in arch/arm and arch/arm64 have been fixed to be compliant. >> >> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx> >> --- >> .../bindings/pci/brcm,iproc-pcie.txt | 133 ------------- >> .../bindings/pci/brcm,iproc-pcie.yaml | 184 ++++++++++++++++++ >> 2 files changed, 184 insertions(+), 133 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/pci/brcm,iproc-pcie.txt >> create mode 100644 Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml:97:34: [warning] too few spaces after comma (commas) > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.example.dt.yaml: pcie@18012000: 'brcm' is a dependency of 'brcm,pcie-ob-axi-offset' > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.example.dt.yaml: pcie@18012000: 'pcie-ob' is a dependency of 'brcm,pcie-ob-axi-offset' > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml OK, so the dependencies must be quoted, but not the properties declaration. Thanks! > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1567483 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > -- Florian
