Hi Rob, Thanks for the review. On 12/13/21 5:35 PM, Rob Herring wrote: > On Fri, Dec 03, 2021 at 10:49:26AM -0300, Ariel D'Alessandro wrote: >> This is a follow up of patchset: >> >> [RFC patch 0/5] Support BCLK input clock in tlv320aic31xx > > Link? Link to the datasheet? http://www.ti.com/lit/ds/symlink/tlv320aic3100.pdf > >> Sound cards may allow using different main clock inputs. In the generic >> fsl-asoc-card driver, these values are hardcoded for each specific card >> configuration. >> >> Let's make it more flexible, allowing setting mclk-id from the >> device-tree node. >> >> Ariel D'Alessandro (4): >> dt-bindings: sound: Rename tlv320aic31xx-micbias as tlv320aic31xx >> dt-bindings: tlv320aic31xx: Define PLL clock inputs >> ASoC: fsl-asoc-card: Add optional dt property for setting mclk-id > > 'mclk-id' is not documented. > >> ASoC: fsl-asoc-card: Remove BCLK default value for tlv320aic31xx card >> >> .../devicetree/bindings/sound/fsl-asoc-card.txt | 1 + >> .../devicetree/bindings/sound/tlv320aic31xx.txt | 2 +- >> arch/arm/boot/dts/am43x-epos-evm.dts | 2 +- >> include/dt-bindings/sound/tlv320aic31xx-micbias.h | 9 --------- >> include/dt-bindings/sound/tlv320aic31xx.h | 14 ++++++++++++++ >> sound/soc/codecs/tlv320aic31xx.c | 2 +- >> sound/soc/fsl/fsl-asoc-card.c | 7 ++++++- >> 7 files changed, 24 insertions(+), 13 deletions(-) >> delete mode 100644 include/dt-bindings/sound/tlv320aic31xx-micbias.h >> create mode 100644 include/dt-bindings/sound/tlv320aic31xx.h >> >> -- >> 2.30.2 Regards, Ariel
