On Fri, Dec 10, 2021 at 08:54:33AM -0600, Rob Herring wrote: > On Tue, Dec 07, 2021 at 10:08:16PM +0100, Jonathan Neuschäfer wrote: > > A nuvoton,*-gcr node is present in nuvoton-common-npcm7xx.dtsi and will > > be added to nuvoton-wpcm450.dtsi. It is necessary for the NPCM7xx and > > WPCM450 pinctrl drivers, and may later be used to retrieve SoC model and > > version information. > > > > This patch adds a binding to describe this node. > > > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx> > > > > --- [...] > > +description: | > > Don't need '|' if no formatting. Ok, I'll drop it. > > + The Global Control Registers (GCR) are a block of registers in Nuvoton SoCs > > + that expose misc functionality such as chip model and version information or > > + pinmux settings. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - nuvoton,wpcm450-gcr > > + - nuvoton,npcm750-gcr > > + - const: syscon > > + - const: simple-mfd > > blank line I'll add it. > > + reg: true > > Need to define how many entries: > > maxItems: 1 Ok > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false Ah, oops, I missed that I still had this line, when I added the child node to the example. > Ideally, you should define the child node names, but you can do this: > > additionalProperties: > type: object > > which means anything undefined must be a node. Ok, makes sense, thanks. Thanks, Jonathan
Attachment:
signature.asc
Description: PGP signature
