On Sat, Dec 11, 2021 at 05:30:57PM +0200, Jarkko Nikula wrote:
> Hi Tony
>
> On 11/25/21 16:48, Tony Lindgren wrote:
> > Commit e428e250fde6 ("ARM: dts: Configure system timers for omap3")
> > caused a timer regression for beagleboard revision c where the system
> > clockevent stops working if omap3isp module is unloaded.
> >
> > Turns out we still have beagleboard revisions a-b4 capacitor c70 quirks
> > applied that limit the usable timers for no good reason. This also affects
> > the power management as we use the system clock instead of the 32k clock
> > source.
> >
> > Let's fix the issue by adding a new omap3-beagle-ab4.dts for the old timer
> > quirks. This allows us to remove the timer quirks for later beagleboard
> > revisions. We also need to update the related timer quirk check for the
> > correct compatible property.
> >
> > Fixes: e428e250fde6 ("ARM: dts: Configure system timers for omap3")
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> > Reported-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxx>
> > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> > ---
>
> > .../devicetree/bindings/arm/omap/omap.txt | 3 ++
> > arch/arm/boot/dts/Makefile | 1 +
> > arch/arm/boot/dts/omap3-beagle-ab4.dts | 47 +++++++++++++++++++
> > arch/arm/boot/dts/omap3-beagle.dts | 33 -------------
> > drivers/clocksource/timer-ti-dm-systimer.c | 2 +-
> > 5 files changed, 52 insertions(+), 34 deletions(-)
> > create mode 100644 arch/arm/boot/dts/omap3-beagle-ab4.dts
> >
> I must have some error in my methodology since I cannot see the issue
> being fixed with your patch :-(
>
Facepalm, as I was expecting I had error in my methodology... see below
> cat arch/arm/boot/dts/omap3-beagle.dtb >>arch/arm/boot/zImage
This I used years before your patch and by some reason I confused to use
new omap3-beagle-ab4.dtb when testing your patch yesterday:
> cat arch/arm/boot/dts/omap3-beagle-ab4.dtb >>arch/arm/boot/zImage
without realizing my Beagle Board version is not between A to B4 but C2.
So when using the omap3-beagle.dtb your patch fixes the regression I
found.
Tested-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxx>
