On 10/12/2021 17:47, Thierry Reding wrote: > From: Thierry Reding <treding@xxxxxxxxxx> > > Document the variant of the memory controller and external memory > controllers found on Tegra234 and add some memory client and SMMU > stream ID definitions for use in device tree files. > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> > --- > Changes in v2: > - conditionally set minItems for reg properties > > .../nvidia,tegra186-mc.yaml | 20 ++++++++++++ > include/dt-bindings/clock/tegra234-clock.h | 9 ++++++ > include/dt-bindings/memory/tegra234-mc.h | 32 +++++++++++++++++++ > 3 files changed, 61 insertions(+) > create mode 100644 include/dt-bindings/memory/tegra234-mc.h > (...) > /** @brief output of mux controlled by CLK_RST_CONTROLLER_CLK_SOURCE_SDMMC4 */ > diff --git a/include/dt-bindings/memory/tegra234-mc.h b/include/dt-bindings/memory/tegra234-mc.h > new file mode 100644 > index 000000000000..2662f70c15c6 > --- /dev/null > +++ b/include/dt-bindings/memory/tegra234-mc.h > @@ -0,0 +1,32 @@ > +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ > + > +#ifndef DT_BINDINGS_MEMORY_TEGRA234_MC_H > +#define DT_BINDINGS_MEMORY_TEGRA234_MC_H > + > +/* special clients */ > +#define TEGRA234_SID_INVALID 0x00 > +#define TEGRA234_SID_PASSTHROUGH 0x7f > + > + > +/* NISO1 stream IDs */ > +#define TEGRA234_SID_SDMMC4 0x02 > +#define TEGRA234_SID_BPMP 0x10 > + > +/* > + * memory client IDs > + */ > + > +/* sdmmcd memory read client */ > +#define TEGRA234_MEMORY_CLIENT_SDMMCRAB 0x63 > +/* sdmmcd memory write client */ > +#define TEGRA234_MEMORY_CLIENT_SDMMCWAB 0x67 > +/* BPMP read client */ > +#define TEGRA234_MEMORY_CLIENT_BPMPR 0x93 > +/* BPMP write client */ > +#define TEGRA234_MEMORY_CLIENT_BPMPW 0x94 > +/* BPMPDMA read client */ > +#define TEGRA234_MEMORY_CLIENT_BPMPDMAR 0x95 > +/* BPMPDMA write client */ > +#define TEGRA234_MEMORY_CLIENT_BPMPDMAW 0x96 > + This header is needed by the driver and DTS patches. One of us can apply it and provide to the other via stable-tag. I think Arnd and Olof prefer if headers are coming with DTS and are provided to other trees, so maybe you will take the bindings and provide a tag for me for the driver? Best regards, Krzysztof
