On 10/12/2021 02.28, Rob Herring wrote:
On Thu, Dec 09, 2021 at 01:32:44PM +0900, Hector Martin wrote:
<snip>
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - apple,aic2
+ then:
+ required:
+ - apple,event-reg
Is this property valid for aic1? If not, you need:
else:
not:
required:
- apple,event-reg
Thanks, I wasn't sure how to do this. Took me a second to realize how
the logic works here, heh.
I tend to think you should just make this a separate document. There's
not a whole lot of sharing (compared to any other interrupt controller).
Good point. I just kind of defaulted to this way because the driver is
the same (and does share a bunch), but indeed the binding doesn't really
reflect any of that. I'll split it off into another document for v2.
Might as well make the 4-argument interrupt form mandatory then (we use
it for all DTs, even the current 1-die machines, on AICv2 SoCs; the
driver can handle both but we might as well be stricter with the binding).
--
Hector Martin (marcan@xxxxxxxxx)
Public Key: https://mrcn.st/pub