* Rafał Miłecki <zajec5@xxxxxxxxx> [211210 11:43]:
> @@ -83,6 +97,28 @@ examples:
> reg = <0x1800c1c0 0x24>;
> reg-names = "cru_gpio_control";
>
> + pins {
> + i2c_scl: i2c_scl {
> + number = <4>;
> + };
> +
> + i2c_sda: i2c_sda {
> + number = <5>;
> + };
> + };
Please don't add custom properties for something that can be done with
standard register based addressing using a hardware offset based reg
property. Your driver can easily translate it. Also, please don't use
custom node names, instead do:
pins {
i2c_scl: pin@0x1234 {
/* Any generic standard properties or numbers here please :)d */
};
...
};
I think I've already commented on the register addressing twice before..
Regards,
Tony
