On Fri, Dec 10, 2021 at 04:40:20PM +0800, JosephCHANG wrote: Follow the subject style used for the directory. 'dt-bindings: net: ...' > For support davicom dm9051 device tree configure Complete sentences please. > > Signed-off-by: JosephCHANG <josright123@xxxxxxxxx> space? ^ > --- > .../bindings/net/davicom,dm9051.yaml | 71 +++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/davicom,dm9051.yaml > > diff --git a/Documentation/devicetree/bindings/net/davicom,dm9051.yaml b/Documentation/devicetree/bindings/net/davicom,dm9051.yaml > new file mode 100644 > index 000000000000..4c2dd0362f7a > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/davicom,dm9051.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/davicom,dm9051.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Davicom DM9051 SPI Ethernet Controller > + > +maintainers: > + - Joseph CHANG <josright123@xxxxxxxxx> > + > +description: | > + The DM9051 is a fully integrated and cost-effective low pin count single > + chip Fast Ethernet controller with a Serial Peripheral Interface (SPI). > + > +allOf: > + - $ref: ethernet-controller.yaml# > + > +properties: > + compatible: > + const: davicom,dm9051 > + > + reg: > + maxItems: 1 > + > + spi-max-frequency: > + maximum: 45000000 > + > + interrupts: > + maxItems: 1 > + > + local-mac-address: true > + > + mac-address: true > + > +required: > + - compatible > + - reg > + - spi-max-frequency > + - interrupts > + > +additionalProperties: false > + > +examples: > + # Raspberry Pi platform > + - | > + /* for Raspberry Pi with pin control stuff for GPIO irq */ > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/gpio/gpio.h> > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + dm9051@0 { ethernet@... > + compatible = "davicom,dm9051"; > + reg = <0>; /* spi chip select */ > + local-mac-address = [00 00 00 00 00 00]; > + pinctrl-names = "default"; > + pinctrl-0 = <ð_int_pins>; > + interrupt-parent = <&gpio>; > + interrupts = <26 IRQ_TYPE_LEVEL_LOW>; > + spi-max-frequency = <31200000>; > + }; > + }; > + gpio { This part is not relevant to the binding example. > + eth_int_pins { > + brcm,pins = <26>; > + brcm,function = <0>; /* in */ > + brcm,pull = <0>; /* none */ > + }; > + }; > -- > 2.20.1 > >