On 10.12.2021 07:53, Lisa Hill wrote:
Set GPIO controlling power for both USB ports properly and add two WAN LEDs and a USB LED missing for the Netgear R6300v2.
Signed-off-by: Lisa Hill <f11o1iomh3dmt141n@xxxxxxxxxx>
Nice work!
One more comment on sending patches: please configure your e-mail client
to send text only (text/plain) without extra HTML version (text/html).
If you can't configure your e-mail easily you can also try
"git send-email" command line tool.
See:
https://www.kernel.org/doc/html/v5.15/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text
https://www.kernel.org/doc/html/v5.15/process/email-clients.html
Also see comments below.
---
.../arm/boot/dts/bcm4708-netgear-r6300-v2.dts | 27 ++++++++++++++++---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
index 4c60eda296d973..5810c95ab239ae 100644
--- a/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
+++ b/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
@@ -34,20 +34,33 @@
linux,default-trigger = "default-on";
};
- power0 {
+ power-green {
label = "bcm53xx:green:power";
gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "default-on";
};
- power1 {
+ power-amber {
label = "bcm53xx:amber:power";
gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
- linux,default-trigger = "default-on";
};
usb {
label = "bcm53xx:blue:usb";
gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
+ trigger-sources = <&ohci_port1>, <&ehci_port1>, <&xhci_port1>;
+ linux,default-trigger = "usbport";
+ };
+
No tabs in empty separator line please.
+ wan-green {
+ label = "bcm53xx:green:wan";
+ gpios = <&chipcommon 10 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "default-on";
I think it's a rather bad idea to blindly set WAN LED on. It should be
up to operating system to decide under what conditions turn it on.
I think you should drop that linux,default-trigger.
+ };
+
No tabs in empty separator line please.
+ wan-amber {
+ label = "bcm53xx:amber:wan";
+ gpios = <&chipcommon 10 GPIO_ACTIVE_HIGH>;
};
It's unlikely both WAN LEDs (green & amber) are controlled by the same
GPIO (10). Please verify that.
