Hi!
On 09/12/2021 00:51, Katherine Perez wrote:
This is a minimal devicetree for Microsoft Surface Duo 2 with SM8350
Chipset
Signed-off-by: Katherine Perez <kaperez@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Vinod Koul <vkoul@xxxxxxxxxx>
---
Changes since v1:
- Change remoteprocs firmware-naming scheme to qcom/sm8350/microsft/*
- Add chassis-type
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../qcom/sm8350-microsoft-surface-duo2.dts | 369 ++++++++++++++++++
2 files changed, 370 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
--
2.31.1
[...]
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sm8350-microsoft-surface-duo2.dts
@@ -0,0 +1,369 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (C) 2021, Microsoft Corporation
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
This is now included in sm8350.dtsi
[...]
+&usb_1 {
+ dr_mode = "peripheral";
+};
+
Looks like you forgot to enable usb_1, but other than these two nits:
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
Konrad
