On 24 August 2014 21:24, Hauke Mehrtens <hauke@xxxxxxxxxx> wrote: > This was copied from arch/mips/bcm47xx/nvram.c and modified to interact > with device tree. My plan is to make the MIPS bcm47xx also use this new > driver some time later. I don't like this. First, you change API (_getenv call), without explanation why/if we really need this. We decided we're very unlikely to ever find devices with multiple (separated) NVRAMs. So what's the point of having nvram per device? Secondly, don't duplicate the code. If you're going to switch bcm47xx to this new code, handle it smarter. Modify bcm47xx mode, move it to the "misc" and re-use in bcm53xx. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
