On Sun 05 Dec 21:58 PST 2021, Vinod Koul wrote: > On 01-12-21, 16:18, Konrad Dybcio wrote: > > > > On 01.12.2021 08:29, Vinod Koul wrote: > > > Enable the UFS and phy node and add the regulators used by them. > > > > > > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx> > > > --- > > > arch/arm64/boot/dts/qcom/sm8450-qrd.dts | 21 +++++++++++++++++++++ > > > 1 file changed, 21 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts > > > index 218eb3ce1ee5..3e65d662ab8c 100644 > > > --- a/arch/arm64/boot/dts/qcom/sm8450-qrd.dts > > > +++ b/arch/arm64/boot/dts/qcom/sm8450-qrd.dts > > > @@ -5,6 +5,7 @@ > > > > > > /dts-v1/; > > > > > > +#include <dt-bindings/gpio/gpio.h> > > > > This should probably go to the SoC DTSI, as it's generally used > > > > in every DT if you have anything more than serial console working.. > > But arent the gpios added in board dts typically? I am okay either > way... Bjorn where would you like this to be..? > Seems like we have this is both board as well as SoC DTS I like Konrad's suggestion of putting it in the dtsi, simply because it saves us from including it in every board file - where it will be needed. Regards, Bjorn > > > > > > Konrad > > -- > ~Vinod
