Re: [PATCH 2/3] dt-bindings: sound: tegra: Update HDA resets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/7/2021 5:32 PM, Dmitry Osipenko wrote:
07.12.2021 14:04, Sameer Pujar пишет:

On 12/7/2021 3:44 PM, Dmitry Osipenko wrote:
07.12.2021 09:32, Sameer Pujar пишет:
Tegra194 HDA has only two resets unlike the previous generations of
Tegra SoCs. Hence update the reset list accordingly.

Fixes: 2d8f8955fe02 ("dt-bindings: tegra: Convert HDA doc to
json-schema")
The original txt binding was already wrong, this "fixes" tag is wrong.
The text didn't document "nvidia,tegra194-hda" compatibile support until
the json-schema conversion happened. Perhaps the text doc was not
updated when Tegra194 support was added. So wouldn't this be right to
use json-schema commit as a base for this?
This problem didn't exist when the binding was converted. Should be
better to drop this tag since it doesn't add much value and creates
confusion, IMO.

It is true that the problem was introduced recently, but from the documentation point of view, given the HW never had this reset it should not have been included in the first place. If it is not useful, I can just drop this tag.



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux