On Mon, Dec 06, 2021 at 11:42:37AM -0600, Rob Herring wrote: > '#interrupt-cells' is not documented which causes a warning when > 'unevaluatedProperties' is implemented. Unless the I2C controller is > also an interrupt controller, '#interrupt-cells' is not valid. This > doesn't appear to be the case from the driver, so just remove it from > the example. > > Cc: Brendan Higgins <brendanhiggins@xxxxxxxxxx> > Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> > Cc: Joel Stanley <joel@xxxxxxxxx> > Cc: Andrew Jeffery <andrew@xxxxxxxx> > Cc: Rayn Chen <rayn_chen@xxxxxxxxxxxxxx> > Cc: linux-i2c@xxxxxxxxxxxxxxx > Cc: openbmc@xxxxxxxxxxxxxxxx > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: linux-aspeed@xxxxxxxxxxxxxxxx > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml | 1 - > 1 file changed, 1 deletion(-) Interestingly I have a patch for this as well but it does the opposite and adds interrupt-controller and #interrupt-cells. Upon closer inspection I was tricked into this because the i2c-aspeed driver includes linux/irqchip/chained_irq.h and linux/irqdomain.h and therefore I assumed that it was indeed implementing an interrupt controller. But none of the symbols in those files are ever used, so your version seems to be correct. Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
