Hi Mauro, On 2021/12/7 16:39, Mauro Carvalho Chehab wrote: > Em Tue, 7 Dec 2021 16:09:16 +0800 > Wei Xu <xuwei5@xxxxxxxxxxxxx> escreveu: > >> Hi Mauro, >> >> On 2021/11/16 19:59, Mauro Carvalho Chehab wrote: >>> From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> >>> >>> Add DTS bindings for the HiKey 970 board's PCIe hardware. >>> >>> Co-developed-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> >>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> >>> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> >>> --- >>> >>> To mailbombing on a large number of people, only mailing lists were C/C on the cover. >>> See [PATCH 0/5] at: https://lore.kernel.org/all/cover.1637063775.git.mchehab+huawei@xxxxxxxxxx/ >>> >>> arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 107 ++++++++++++++++++++++ >>> 1 file changed, 107 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/hisilicon/hi3670.dtsi b/arch/arm64/boot/dts/hisilicon/hi3670.dtsi >>> index 636c8817df7e..225dccbcb064 100644 >>> --- a/arch/arm64/boot/dts/hisilicon/hi3670.dtsi >>> +++ b/arch/arm64/boot/dts/hisilicon/hi3670.dtsi >>> @@ -176,6 +176,12 @@ sctrl: sctrl@fff0a000 { >>> #clock-cells = <1>; >>> }; >>> >>> + pmctrl: pmctrl@fff31000 { >>> + compatible = "hisilicon,hi3670-pmctrl", "syscon"; >> >> The "hi3670-pmctrl" is not documented in the devicetree binding documents yet. >> Could we remove this part this time? > > Without that, the PCI PHY won't work. > > IMO, the best would be to just add this compatible to hi3670-clock, > where it belongs. > > Just sent a patch. Got it. Thanks! Best Regards, Wei > > Regards, > Mauro > > . >
