Hi Biju,
On Fri, Dec 3, 2021 at 12:52 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> The Renesas RZ/G2{L, LC} SoC (a.k.a R9A07G044) has a Bifrost Mali-G31 GPU,
> add a compatible string for it.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> @@ -52,7 +64,8 @@ properties:
> maxItems: 3
>
> resets:
> - maxItems: 2
> + minItems: 1
2, as before?
> + maxItems: 3
Perhaps you should add reset-names?
>
> "#cooling-cells":
> const: 2
> @@ -113,6 +126,21 @@ allOf:
> - sram-supply
> - power-domains
> - power-domain-names
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,r9a07g044-mali
> + then:
> + properties:
> + interrupt-names:
> + minItems: 4
> + clock-names:
> + minItems: 3
> + required:
> + - clock-names
> + - power-domains
> + - resets
reset-names
> else:
> properties:
> power-domains:
The rest looks good to me, but I'm no Mali expert.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
